Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accept request crash if submitted too early #727

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Jul 5, 2023

Fixes https://rainbow-me.sentry.io/issues/4286489515/?environment=production&project=4504012577112064&query=is%3Aunresolved&referrer=issue-stream&stream_index=13
Figma link (if any):

What changed (plus any additional context for devs)

If the app session is still bootstrapping after unlocking, there's no selected wallet, so we're disabling the action until we have one.

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Here's the packed extension for this build:
rainbowbx-3f37444cc8503d41d136363994d0bad2ae4c8dca.zip

@brunobar79 brunobar79 changed the title Fix accept request crash if submitted to early Fix accept request crash if submitted too early Jul 6, 2023
Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brunobar79 brunobar79 merged commit c12c049 into master Jul 6, 2023
@brunobar79 brunobar79 deleted the @bruno/fix-send-too-early branch July 6, 2023 19:11
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Here's the packed extension for this build:
rainbowbx-c12c04919a915363e2726279766d43aa65c431c4.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants