Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: native field as input in swap #702

Merged
merged 21 commits into from
Jul 3, 2023
Merged

feat: native field as input in swap #702

merged 21 commits into from
Jul 3, 2023

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jun 28, 2023 •
edited
Loading

Fixes BX-827
Fixes BX-800

Figma link (if any):

What changed (plus any additional context for devs)

  • native field is now an input, will be disabled if there's no price for the asset

plz try to break it, thx

Screen recordings / screenshots

https://www.loom.com/share/d9aa3476310b45439f757164890b2883

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jun 28, 2023

BX-800 I expected to be able to type into the USD value during Swap flow as if it was an input

Screenshot 2023-06-09 at 12.48.04 PM.png

BX-827 I keep trying to use the native input ($ value input) for swap

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a39b03976e6e277ea6af34a970b1b1c66bc61a07.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-316e6d0367a3b8c0c1e44460a8b9ce250e3cb07f.zip

@estebanmino estebanmino marked this pull request as ready for review June 28, 2023 20:22
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6550e8fbbbbdb34900b5e5d2bcc0cd0d0b8f3952.zip

derHowie
derHowie approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just 1 question

src/entries/popup/pages/swap/index.tsx Outdated
assetToSellNativeValue={assetToSellNativeValue}
/>
</AccentColorProviderWrapper>
<Box>
Copy link
Member

@derHowie derHowie Jun 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does wrapping this in <Box /> do something?

src/entries/popup/pages/swap/index.tsx Outdated
assetToSellNativeValue={assetToSellNativeValue}
/>
</AccentColorProviderWrapper>
<Box>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be intentional. What effect does this have?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah probably nothing, will remove

brunobar79
brunobar79 approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ba62022864eaaefc587b395d80c8dffd6a3c5136.zip

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9c17d14493467c0d105b7a74efc0326fb56c134a.zip

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-1d76111fca0c740126d2cd39a89d75e9dfe676f8.zip

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9ddb91f2a16ff877851b4a329b67f11a4081a4e4.zip

@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0b36134b199435b6654fdbabc8050fa2993a51bf.zip

@estebanmino estebanmino merged commit 204b80d into master Jul 3, 2023
@estebanmino estebanmino deleted the @esteban/swap-native-input branch July 3, 2023 15:35
@github-actions
Copy link

github-actions bot commented Jul 3, 2023

Here's the packed extension for this build:
rainbowbx-204b80dc70bc1d538d664e00ed4d12523cced68a.zip

BrodyHughes pushed a commit that referenced this pull request Jul 5, 2023
@estebanmino @BrodyHughes
feat: native field as input in swap (#702)
e57746a
@DanielSinclair DanielSinclair mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @brunobar79 @derHowie