Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BX-805] Expected to be able to press "ENTER" to submit my Swap #699

Merged
merged 7 commits into from
Jun 30, 2023
Merged

[BX-805] Expected to be able to press "ENTER" to submit my Swap #699

merged 7 commits into from
Jun 30, 2023

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

You can now access the confirm swap submit button with the keyboard. The cta on the swap review sheet is now auto focused when it pulls up, which satisfies the ticket's requirements. The user can hit enter to submit the swap unless the use the arrows keys or tab to focus a different button.

Screen recordings / screenshots

https://recordit.co/vAr9Rd6Lqn

What to test

Make sure the cta in the swap review sheet auto focuses

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jun 26, 2023

BX-805 Expected to be able to press "ENTER" to submit my Swap

Screenshot 2023-06-09 at 12.52.27 PM.png

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0b94828ffb4aa6de2dc3dc6d22587c7cbeb13c5c.zip

brunobar79
brunobar79 approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UX 📈📈📈

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-f7eed3b823bb4794c037e31a3a6e9b0280e71e5c.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-6948a63df18c62d6cfbb8e2565dc921403639ff0.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-e1426acbc05ae18ee4d650995cfba46f2bccb0c4.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-81d68259b2651fde979772de75c2e10ff6e5c818.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-324f6e9809cbb763001f72aa2ff8fd0fd95287c1.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-501f1991b9ef90fd73c103c1ec5c5fb93731cf2b.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-501f1991b9ef90fd73c103c1ec5c5fb93731cf2b.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-002f8fc61442824442a81473f2c1073e03b540e1.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2cca75e33931e1a466369b6b0f6b5849c45ec1af.zip

estebanmino
estebanmino approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-653259cec9bb37e6418d83f5b42273b780fe572d.zip

@derHowie derHowie merged commit a13f814 into master Jun 30, 2023
@derHowie derHowie deleted the @chris/enter-to-swap branch June 30, 2023 22:29
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-a13f8147a4faaa7c4954b1846f02d8c266db87b2.zip

greg-schrammel pushed a commit that referenced this pull request Jul 1, 2023
@derHowie @greg-schrammel
[BX-805] Expected to be able to press "ENTER" to submit my Swap (#699)
76e2356
BrodyHughes pushed a commit that referenced this pull request Jul 5, 2023
@derHowie @BrodyHughes
[BX-805] Expected to be able to press "ENTER" to submit my Swap (#699)
2148168
@DanielSinclair DanielSinclair mentioned this pull request Jul 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derHowie @brunobar79 @estebanmino