[BX-832] Dismiss Alert prompts by clicking blurred background area #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BX-832 Dismiss Alert prompts by clicking blurred background area
Rather that defocussing input, we should activate the Cancel/Dismiss action when user clicks in background area. This click should be interpreted as cancel/dismiss nondestructive action only. |
|
Here's the packed extension for this build: |
brunobar79
approved these changes
Jun 26, 2023
|
Here's the packed extension for this build: |
estebanmino
approved these changes
Jun 26, 2023
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Passing an optional handleClose prop to the Prompt component now allows the user to click the background to close prompts
Screen recordings / screenshots
https://recordit.co/NtsTVrKtYQ
What to test
Make sure clicking the bg closes alerts/prompts
Final checklist
yarn build).