[BX-790][BX-728] Hide Back Button When Navigating to Full Screen #693
Conversation
BX-790 Nav not working when HW flow (not onboarding)
i can't get out of the import hw flow pressing the We need to hide the X since there's nowhere else to go. |
|
Here's the packed extension for this build: |
| @@ -14,7 +14,7 @@ export const useNavigateToSwaps = () => { | |||
|
|
|||
| return () => { | |||
| return type === KeychainType.HardwareWalletKeychain && !isFullScreen | |||
| ? goToNewTab({ url: POPUP_URL + `#${ROUTES.SWAP}` }) | |||
| ? goToNewTab({ url: POPUP_URL + `#${ROUTES.SWAP}?hideBack=true` }) | |||
There was a problem hiding this comment.
shouldn't this use location state to pass these flags as we do for other routes?
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
What changed (plus any additional context for devs)
I am passing params in the URL to hide the back buttons when we navigate to the browser on a screen with a navbar from the extension. This solution is pretty manual. Lmk if you have an ideas on how to do this cleaner.
Screen recordings / screenshots
Add HWW Flow: https://recordit.co/RTgk2yVrDE
HWW Swap Flow: https://recordit.co/OPAYYjFDZ3
What to test
Ensure we aren't hiding the back buttons in scenarios where we want it to appear.
Final checklist
yarn build).