Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wallet avatar empty address #676

Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix: wallet avatar empty address #676

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68e7725
fix
estebanmino Jun 20, 2023
93e9c82
Merge branch 'master' into @esteban/wallet-avatar-fix
estebanmino Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/entries/popup/components/WalletAvatar/WalletAvatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ export function WalletAvatar({
overflow: 'hidden',
}}
>
{isFetched ? (
{isFetched && address ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't we use isSuccess instead of isFetched?
I'd think if there is no address isSuccess === false && isError === true

<>
{avatar?.imageUrl ? (
<Avatar.Image mask={mask} size={size} imageUrl={avatar.imageUrl} />
Expand Down