Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List performance #675

Merged
merged 5 commits into from
Jun 21, 2023
Merged

List performance #675

merged 5 commits into from
Jun 21, 2023

Conversation

greg-schrammel
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

before/after

Screen.Recording.2023-06-19.at.19.46.37.mov
Screen.Recording.2023-06-19.at.19.42.39.mov

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-8bc0f1f152aea144f0a3a7da3f0d994d80261f31.zip

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legend 🔥 🔥 🔥

Tested vitalik's wallet and this is a huge improvement

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c2146a28b746a9f708f775679aecdd24929c583d.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0b8426ca97d81ea4d5c37141441b2c9a54650464.zip

@greg-schrammel greg-schrammel merged commit 2b72a91 into master Jun 21, 2023
@greg-schrammel greg-schrammel deleted the list-performance branch June 21, 2023 13:54
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2b72a9108f26697e2aff1c680c5fd7fbe6b0cecd.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants