Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

analytics: settings.flashbots.disabled, settings.flashbots.enabled #657

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Jun 14, 2023

Fixes BX-705
Figma link (if any):

What changed (plus any additional context for devs)

  • added settings.flashbots.disabled event
  • added settings.flashbots.enabled event
  • created setGlobalFlashbotsEnabled callback handler to mirror analytics implementation for settings.rainbow_default_provider.disabled and settings.rainbow_default_provider.enabled

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jun 14, 2023

BX-705 Global flashbots setting tracking

Fire unique events when the global Flashbots toggle Setting is enabled or disabled

settings.flashbots.enabled

settings.flashbots.disabled

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-05577202aab006c2d83183d4082b8b7a7287a57d.zip

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-ea1c2562bee86753b643602ad2e0df6eb1cb1472.zip

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-c5ec8f89231c85fa85eb0013f06bcab1faabdada.zip

@estebanmino estebanmino merged commit 49c9c13 into master Jun 20, 2023
@estebanmino estebanmino deleted the @daniel/analytics-flashbots-setting branch June 20, 2023 20:57
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-49c9c135cc05ebee667c10e4b44c7fc7e288c37a.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants