Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update watch wallet recommendations #633

Merged
merged 7 commits into from
Jun 20, 2023
Merged

chore: update watch wallet recommendations #633

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
20902cc
chore: amend recommendedTopAccounts list
DanielSinclair Jun 8, 2023
702ef98
feat: added shuffle to the recommendedTopAccounts list
DanielSinclair Jun 8, 2023
bb659b1
Merge branch 'master' into @daniel/watch-list
DanielSinclair Jun 8, 2023
b362198
Merge branch 'master' into @daniel/watch-list
DanielSinclair Jun 9, 2023
ade682f
Merge branch 'master' into @daniel/watch-list
DanielSinclair Jun 14, 2023
9de90fb
Merge branch 'master' into @daniel/watch-list
DanielSinclair Jun 14, 2023
01841b3
Merge branch 'master' into @daniel/watch-list
estebanmino Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 25 additions & 4 deletions src/entries/popup/components/WatchWallet/WatchWallet.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,32 @@ import { WalletAvatar } from '../WalletAvatar/WalletAvatar';

const recommendedTopAccounts = [
'vitalik.eth',
'bored.eth',
'skillet.eth',
'worm.eth',
'nickbytes.eth',
'gami.eth',
'maaria.eth',
'cdixon.eth',
'hublot.eth',
'rainbowwallet.eth',
];
'nick.eth',
'sassal.eth',
'shaq.eth',
'simona.eth',
'sohrab.eth',
'sadaf.eth',
'nnnnicholas.eth',
'dom.eth',
'poap.eth',
'dwr.eth',
'jacob.eth',
'callil.eth',
'johnpalmer.eth',
'shl0ms.eth',
'gremplin.eth',
'chrismartz.eth',
] // shuffle the list
.map((value) => ({ value, sort: Math.random() }))
.sort((a, b) => a.sort - b.sort)
.map(({ value }) => value);
Comment on lines +65 to +67
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion

Suggested change
.map((value) => ({ value, sort: Math.random() }))
.sort((a, b) => a.sort - b.sort)
.map(({ value }) => value);
.sort(() => 0.5 - Math.random());


function RecommendedAccountRow({
name,
Expand Down