fix: show referral and referral activity points when empty #1642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
DanielSinclair
approved these changes
Jul 24, 2024
magiziz
reviewed
Jul 24, 2024
| @@ -85,6 +85,14 @@ export const getWeeklyEarnings = (points: PointsQuery['points']) => { | |||
| !(['retroactive', 'redemption'].includes(d.type) && d.earnings === 0), | |||
| ); | |||
|
|
|||
| if (!diffs.find((d) => d.type === 'new_referrals')) { | |||
There was a problem hiding this comment.
We have a function called isLowerCaseMatch if that's helpful to add here.
magiziz
approved these changes
Jul 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Here's the packed extension for this build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1287
What changed (plus any additional context for devs)
Users with empty referral activity will now always see referral line items in the weekly summary even if empty ("none").
Screen recordings / screenshots
What to test
Ensure these line items appear for addresses with no activity for a given week.