fix: disable activity details shortcuts without dropdown #1640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
magiziz
approved these changes
Jul 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Here's the packed extension for this build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1565
What changed (plus any additional context for devs)
From ticket:
"Goal:
Only register Token Details shortcuts when the context menu is visibile
Allow a user to select text and copy"
The shortcuts associated with the more options menu in token details now are only active when the dropdown is visible.
What to test
Make sure that token details does not intercept the 'C' key when the more options dropdown is hidden.