feat: custom gas in all networks #1631
Conversation
estebanmino
requested review from
DanielSinclair,
BrodyHughes,
derHowie and
magiziz
|
Here's the packed extension for this build: |
| const [gasPriceWarning, setGasPriceWarning] = useState< | ||
| 'stuck' | 'fail' | undefined | ||
| >(undefined); |
There was a problem hiding this comment.
Maybe we can do something like this ?
const [gasPriceWarning, setGasPriceWarning] = useState<'stuck' | 'fail'>();
src/entries/popup/hooks/useGas.ts
Outdated
| useEffect(() => { | ||
| if ( | ||
| !gasData || | ||
| !enabled || | ||
| prevDebouncedGasPrice === debouncedGasPrice || | ||
| feeType !== 'legacy' || | ||
| !nativeAsset | ||
| ) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Can we use useQuery here ?
There was a problem hiding this comment.
hm yeah let me try refactoring this
estebanmino
force-pushed
the
@esteban/enable-custom-gas
branch
from
ae0e2f1
to
b04489f
Compare
|
@magiziz I just applied your comments! 🙏 |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Functionality seems good to me. For this sort of case we should do a '<0.001' or something though: 
|
|
@BrodyHughes Which network was that? Wonder if it is a bad result from Backend |
|
Lgtm. Have a few design tweaks for existing Custom Gas UI problems, so will create a seperate polish ticket for that and carry over Brody's issue |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Here's the packed extension for this build: |
Fixes BX-1546, BX-1507
Figma link (if any):
What changed (plus any additional context for devs)
enabling custom gas in all networks for all txs types
Screen recordings / screenshots
https://www.loom.com/share/19d39fed3c1040c29ae00a41eddc8a81
What to test