Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1545] fix: prevent touchpad dbltap zoom #1621

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Jul 10, 2024

What changed (plus any additional context for devs)

Disabled default behavior when we receive a 'wheel' event with the ctrlKey field set to true.

Screen recordings / screenshots

Pretend I posted a video of nothing happening.

What to test

Attempt to zoom in on the application using the 2 finger double tap gesture on the touchpad.

Copy link

linear bot commented Jul 10, 2024

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0ed3800873552ab439c85759132757a9711b1bbc

Copy link

Here's the packed extension for this build:
rainbowbx-0ed3800873552ab439c85759132757a9711b1bbc

@DanielSinclair
Copy link
Collaborator

Perfect 👌

@DanielSinclair DanielSinclair added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@derHowie derHowie added this pull request to the merge queue Jul 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Jul 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 18, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Jul 18, 2024
Merged via the queue into master with commit 5e33729 Jul 18, 2024
17 checks passed
@DanielSinclair DanielSinclair deleted the @chris/prevent-dbltap-zoom branch July 18, 2024 05:57
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-5e33729e962df510887004aae6b8fd3fad36d47d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants