fix: window. rainbow providers #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estebanmino
assigned derHowie, BrodyHughes and magiziz and unassigned derHowie, BrodyHughes and magiziz
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
BrodyHughes
approved these changes
Jul 3, 2024
|
Here's the packed extension for this build: |
DanielSinclair
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
window.rainbow.providerswas only defined once at the beginning, so any updates tornbwWalletRouter.providerswon't be reflected inwindow.rainbow.providers, in which case were rainbow provider iswindow.ethereumthewindow.ethereum.providerswould only have the first definition ofwindow.rainbow.providersat the beginningEDIT
ended up removing
isMetaMaskflag whenannounceProviderScreen recordings / screenshots
What to test