Rounding large numbers

[BrodyHughes]

Fixes BX-1550, BX-121, BX-1551

What changed:

• this PR effects the swap review cards and the swap review
• follow up PRs to follow changing this behavior elsewhere in the app
• numbers >= 1,000 are now abbreviated using K, M, B, T, etc.

Screen recordings / screenshots

New behavior:

What to test

• do large and small values round correctly on the review cards

[linear]

BX-1550 Round Swap Review bubble values

[github-actions]

Here's the packed extension for this build:
rainbowbx-413018a685e09f9c7d8952093de9d6397610631d

[estebanmino]

i think @greg-schrammel already did this before ?

[greg-schrammel]

yep formatNumber takes an options arg that you can add notation: 'compact'

import { formatCurrency } from '~/core/utils/formatNumber';

formatCurrency(num, { notation: 'compact', maximumSignificantDigits: 4 });

[linear]

BX-1551 Exchange rate line item overflow on Swap Review sheet

[github-actions]

Here's the packed extension for this build:
rainbowbx-f73dbb0313522c016d42916b6a62523d56654506

[DanielSinclair]

It looks like we're accidentally appending a $ to the swap bubble values

[BrodyHughes]

It looks like we're accidentally appending a $ to the swap bubble values

fixed this concern. nice catch.

[github-actions]

Here's the packed extension for this build:
rainbowbx-e94d026f56a5f51de234d52ad4a3c7f4b91109bc

[derHowie]

👌

[github-actions]

Here's the packed extension for this build:
rainbowbx-4140d8cdc9ce754666d2090b33df2c91a4a20275