feat: wallet_revokePermissions #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@rainbow-me/[email protected] |
estebanmino
force-pushed
the
@esteban/wallet_revokePermissions
branch
from
37f4712
to
ee025c6
Compare
estebanmino
requested review from
DanielSinclair,
derHowie,
BrodyHughes and
magiziz
magiziz
approved these changes
Jun 17, 2024
|
Here's the packed extension for this build: |
|
@estebanmino There is a bug in RainbowKit when doing |
DanielSinclair
approved these changes
Jun 18, 2024
|
Here's the packed extension for this build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1502
Figma link (if any):
What changed (plus any additional context for devs)
adding support for
wallet_revokePermissionsit needs this one merged first rainbow-me/provider#17
Screen recordings / screenshots
Screen.Recording.2024-06-13.at.14.37.00.mov
What to test