Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: approve tx to #1573

Merged
merged 3 commits into from
Jun 17, 2024
Merged

fix: approve tx to #1573

merged 3 commits into from
Jun 17, 2024

Conversation

estebanmino
Copy link
Contributor

Fixes BX-1498
Figma link (if any):

What changed (plus any additional context for devs)

now displaying approval to correctly
now using meta.type for this method since type is deprecated

Screen recordings / screenshots

What to test

Copy link

linear bot commented Jun 11, 2024

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-1521b0283e02db196c8c42b828002230ddf73623

@DanielSinclair DanielSinclair self-requested a review June 14, 2024 20:03
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-71808644b0b7b2efd0784852bbf1bea241a95c25

@DanielSinclair DanielSinclair added this pull request to the merge queue Jun 15, 2024
Copy link

Here's the packed extension for this build:
rainbowbx-ea74cfc6fb2aa8709eda09dfb25c532bd84449fb

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 15, 2024
@DanielSinclair DanielSinclair added this pull request to the merge queue Jun 17, 2024
Merged via the queue into master with commit 87cac2e Jun 17, 2024
15 checks passed
@DanielSinclair DanielSinclair deleted the @esteban/fix-approve-tx-to branch June 17, 2024 06:35
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-87cac2e15fbdcc0e0c1b4c1cfd0ff54b940b43fc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants