Merge keychains #1435
Merged
Merge keychains #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
estebanmino
reviewed
Mar 27, 2024
estebanmino
reviewed
Mar 28, 2024
src/entries/popup/components/ImportWallet/ImportWalletSelection.tsx
Outdated
Show resolved
Hide resolved
estebanmino
approved these changes
Apr 30, 2024
|
Here's the packed extension for this build: |
derHowie
approved these changes
May 13, 2024
|
Here's the packed extension for this build: |
|
@greg-schrammel After you wrap up Degen Mode, if you could have a look at this and merge |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1602
Figma link (if any):
What changed (plus any additional context for devs)
merge pks to it's hd group when possible
in the clip I added by pk the index 2 of a seed phrase, later when I add this seed phrase and click to create a wallet in the second index, it merges both into a single group (removes the pk keychain and merges all into the hd)
Screen.Recording.2024-02-20.at.14.15.04.mov
Screen.Recording.2024-02-20.at.14.16.07.mov
importing a duplicate pk, will just select the account
Screen.Recording.2024-02-20.at.14.20.16.mov
trying to import the same seed twice with prompt an error with "This seed is imported already" (maybe we need a better message here)
Screen recordings / screenshots
What to test