Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date on points terminal #1409

Merged
merged 3 commits into from
Mar 15, 2024
Merged

Fix date on points terminal #1409

merged 3 commits into from
Mar 15, 2024

Conversation

BrodyHughes
Copy link
Member

Fixes BX-1343
Figma link (if any):

What changed (plus any additional context for devs)

needed to * 1000 the date. was returning the value in miliseconds, not seconds. the actual returned date was Jan of 1970 lol

Screen recordings / screenshots

Screenshot 2024-03-15 at 1 41 42 PM

Copy link

linear bot commented Mar 15, 2024

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-71db8e5801678f54b8aa5d6c4c2935d2030680ca.zip
screenshots

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0b7e28b31a6814f16a4d2648328919850e376bad.zip

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@types/[email protected] None 0 25.7 kB types
npm/@types/[email protected] None 0 3.55 MB types
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +127 49.9 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +113 45.2 MB jameshenry
npm/@typescript-eslint/[email protected] None +2 620 kB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +119 45.9 MB jameshenry
npm/@typescript-eslint/[email protected] None 0 223 kB jameshenry
npm/@typescript-eslint/[email protected] environment, filesystem +32 34.2 MB jameshenry
npm/@typescript-eslint/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +118 45.8 MB jameshenry
npm/@typescript-eslint/[email protected] None +2 272 kB jameshenry
npm/[email protected] None 0 4.42 kB blakeembrey
npm/[email protected] None 0 3.9 kB sindresorhus
npm/[email protected] None 0 4.85 kB dmnd
npm/[email protected] None 0 53.6 kB kikobeats
npm/[email protected] None 0 7.86 kB dougwilson
npm/[email protected] unsafe Transitive: environment, filesystem +2 290 kB evilebottnawi
npm/[email protected] Transitive: eval +35 3.29 MB ljharb
npm/[email protected] None 0 86.9 kB guybedford
npm/[email protected] environment, filesystem, network, shell 0 88 kB evanw
npm/[email protected] None 0 3.66 kB dougwilson
npm/[email protected] None +3 165 kB eslintbot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +91 10.6 MB eslintbot
npm/[email protected] None 0 1 MB michaelficarra
npm/[email protected] filesystem 0 10.8 kB dougwilson
npm/[email protected] None 0 38 kB lpinca
npm/[email protected] None 0 13 kB esp
npm/[email protected] None 0 2.95 kB sindresorhus
npm/[email protected] eval +3 85.7 kB ljharb
npm/[email protected] environment, filesystem 0 32.5 kB isaacs
npm/[email protected] None 0 12.1 kB indutny
npm/[email protected] None 0 12.8 kB ljharb
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None 0 124 kB mathias
npm/[email protected] None 0 25.8 kB nlf
npm/[email protected] None 0 13.9 kB indutny
npm/[email protected] Transitive: environment, eval +5 70.7 kB dougwilson
npm/[email protected] Transitive: environment, filesystem +4 384 kB evilebottnawi
npm/[email protected] None 0 48.9 kB kael
npm/[email protected] None 0 14.6 kB cwmma
npm/[email protected] None 0 42.1 kB whitequark
npm/[email protected] None 0 5.01 kB wooorm
npm/[email protected] None 0 28.9 kB ljharb
npm/[email protected] None +2 56 kB ljharb
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None 0 4.99 kB wooorm
npm/[email protected] None +2 50.6 kB ljharb
npm/[email protected] None +1 42.6 kB ljharb
npm/[email protected] None 0 75.8 kB jdalton
npm/[email protected] environment, filesystem 0 51.7 kB broofa
npm/[email protected] None 0 24.4 kB ai
npm/[email protected] environment, filesystem, network, shell, unsafe +26 1.12 GB vercel-release-bot
npm/[email protected] None 0 1.66 MB davidlehn
npm/[email protected] None 0 93.6 kB ljharb
npm/[email protected] Transitive: eval +8 1.31 MB ljharb
npm/[email protected] None 0 19.1 kB indutny
npm/[email protected] environment, filesystem, shell +3 57.6 kB sindresorhus
npm/[email protected] None +6 161 kB gkz
npm/[email protected] None 0 10.3 kB dougwilson
npm/[email protected] None 0 4.55 kB sindresorhus
npm/[email protected] unsafe 0 13.5 kB danez
npm/[email protected] None +2 206 kB evilebottnawi
npm/[email protected] None 0 27.2 kB evilebottnawi
npm/[email protected] environment, filesystem +3 374 kB ai
npm/[email protected] environment, filesystem, unsafe 0 8.39 MB prettier-bot
npm/[email protected] None 0 8.46 kB dougwilson
npm/[email protected] environment +4 4.93 MB gnoff
npm/[email protected] environment +2 337 kB gnoff
npm/[email protected] Transitive: eval +9 200 kB ljharb
npm/[email protected] environment, filesystem +5 216 kB ljharb
npm/[email protected] environment Transitive: eval +8 1.67 MB evilebottnawi
npm/[email protected] None +2 55.4 kB redonkulus
npm/[email protected] None 0 6.96 kB sindresorhus
npm/[email protected] environment +3 1.37 MB vercel-release-bot
npm/[email protected] None 0 46.9 kB sokra
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +76 19.7 MB evilebottnawi
npm/[email protected] environment, eval Transitive: filesystem, shell +11 4.18 MB fabiosantoscode
npm/[email protected] shell 0 7.82 kB wmhilton
npm/[email protected] None +1 57.9 kB gkz
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] None 0 4.31 kB dougwilson
npm/[email protected] environment, filesystem, network, unsafe Transitive: eval, shell +76 19.7 MB evilebottnawi

🚮 Removed packages: npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@babel/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-codegen/[email protected], npm/@graphql-eslint/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@graphql-tools/[email protected], npm/@repeaterjs/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/@typescript-eslint/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package Note
Telemetry npm/[email protected]
  • Note: Can be disabled by setting the environment variable NEXT_TELEMETRY_DISABLED=1 . See https://nextjs.org/telemetry for more information

View full report↗︎

Next steps

What is telemetry?

This package contains telemetry which tracks how it is used.

Most telemetry comes with settings to disable it. Consider disabling telemetry if you do not want to be tracked.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-76202f1356d5c9e1fa05fb774fd63ce14d742ed0.zip

@DanielSinclair
Copy link
Collaborator

Resolved GHSA-cxjh-pqwp-8mfp here too to unblock audit

@DanielSinclair DanielSinclair added this pull request to the merge queue Mar 15, 2024
Copy link

Here's the packed extension for this build:
rainbowbx-76202f1356d5c9e1fa05fb774fd63ce14d742ed0.zip

Merged via the queue into master with commit 2065037 Mar 15, 2024
16 of 17 checks passed
@DanielSinclair DanielSinclair deleted the brody/fix-date branch March 15, 2024 22:26
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-206503747c320e140bb0fc52a67e1086d4123f89.zip
screenshots

greg-schrammel pushed a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants