Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: estimate unlock and swap using metadata #1395

Merged
merged 5 commits into from
Mar 27, 2024
Merged

feat: estimate unlock and swap using metadata #1395

merged 5 commits into from
Mar 27, 2024

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Mar 13, 2024 •
edited
Loading

Fixes BX-1351
Figma link (if any):

What changed (plus any additional context for devs)

adding support for metadata to get unlock and swap estimates from BE metadata

Screen recordings / screenshots

What to test

@linear Linear
Copy link

linear bot commented Mar 13, 2024

BX-1351 use metadata for unlock and swap gas estimations

@estebanmino estebanmino marked this pull request as ready for review March 13, 2024 18:35
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-da9cf57f34f5df87ddc44def7bc6b3f95698c3a4.zip

derHowie
derHowie approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@estebanmino estebanmino force-pushed the @esteban/estimate-unlock-and-swap branch from 02508e1 to 243d043 Compare March 21, 2024 16:19
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-f8e6b784a8eb26f8df151fea15f3e175c3dc5773.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-810eedbc67bec398a565a808d56c193335229f1b.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-810eedbc67bec398a565a808d56c193335229f1b.zip

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c120f875352bebdf5ba57166dc0dbb2ecc026b82.zip
screenshots

@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-f3217459fa07d5d0292d5de5cb53b68d6487966c.zip

@estebanmino estebanmino added this pull request to the merge queue Mar 27, 2024
Merged via the queue into master with commit 776abe5 Mar 27, 2024
17 checks passed
@estebanmino estebanmino deleted the @esteban/estimate-unlock-and-swap branch March 27, 2024 16:33
@github-actions GitHub Actions
Copy link

Here's the packed extension for this build:
rainbowbx-776abe5fda7f8059adfbb2cc73a109ae2a206564.zip

@DanielSinclair DanielSinclair mentioned this pull request Mar 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@brunobar79 brunobar79 Awaiting requested review from brunobar79

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @greg-schrammel @derHowie