feat: pin / unpin tokens #1370
feat: pin / unpin tokens #1370
Conversation
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
@kosmoskey A few tweaks!
|
|
Here's the packed extension for this build: |
|
@BrodyHughes Updated 🙏
|
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
| ), | ||
| 'uniqueId', | ||
| ), | ||
| const combinedAssets = useMemo( |
There was a problem hiding this comment.
@kosmoskey Looks like there is a merge conflict with #1383 here and that new logic should be kept. I think we also typically perform filters in-line instead of a separate hook, so I'd suggest we refactor to shift to that. Maybe a usePinnedAssets hook would be broken out, and then the combined filters would be inline here
magiziz
force-pushed
the
@mago/pin-unpin-tokens-homescreen
branch
from
cadf849
to
01eb8ca
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
|
@SocketSecurity ignore-all |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Co-authored-by: Magomed Khamidov <[email protected]> Co-authored-by: Daniel Sinclair <[email protected]> Co-authored-by: Esteban Miño <[email protected]>
Co-authored-by: Magomed Khamidov <[email protected]> Co-authored-by: Daniel Sinclair <[email protected]> Co-authored-by: Esteban Miño <[email protected]>
Fixes BX-1328
Figma link (if any):
Screen recordings / screenshots
pin_unpin_tokens.mov
What to test