[BX-1314][BX-1315] Support Additional Simplehash Networks + Configure Testnet NFT Request #1336
Conversation
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
derHowie
requested review from
greg-schrammel,
estebanmino and
DanielSinclair
|
Here's the packed extension for this build: |
src/core/resources/nfts/nfts.ts
Outdated
| ); | ||
| const chains = !testnetMode | ||
| ? (getSimpleHashSupportedChainNames() as ChainName[]) | ||
| : (getSimpleHashSupportedTestnetChainNames() as ChainName[]); |
There was a problem hiding this comment.
this means that we're not filtering nfts by enabled chains from settings anymore?
There was a problem hiding this comment.
oh wait, do we even filter by enabled chain?
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
| nft?.network === 'mainnet' ? 'Ethereum' : capitalize(nft?.network); | ||
| const networkDisplay = nft?.network | ||
| ? ChainNameDisplay[chainIdFromChainName(nft?.network)] | ||
| : ''; |
There was a problem hiding this comment.
is this '' just used as a "falsy" value?
There was a problem hiding this comment.
Yes, just not showing that row if nft is undefined. Just being safe, that shouldn't be the case unless something broke.
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
… Testnet NFT Request (#1336)
… Testnet NFT Request (#1336)
… Testnet NFT Request (#1336)
What changed (plus any additional context for devs)
Added support for all available networks returned by Simplehash that also overlapped with Viem's supported network list. Partitioned mainnet and testnet nft network lists and now return testnet NFTs in dev mode.
Screen recordings / screenshots
PoW: https://recordit.co/jowwjwvIp2
What to test
Ensure NFTs on networks that are currently unsupported, but added to the Simplehash request in this PR appear. Also ensure that testnet nfts only appear while dev mode is activated.