Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom gas shortcuts on L2s #1321

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Conversation

BrodyHughes
Copy link
Member

while writing e2e i realized we could still open up the custom gas sheet on L2s with shortcut 'c' and on Polygon this caused a crash. This makes it so 'g' and 'c' shortcuts only work on mainnet, and the 'g' menu only works on polygon.

POW:

Screen.Recording.2024-01-25.at.1.39.18.PM.mov

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-36af41c932f0e9e6a6f7bc72714ce24b543efe2c.zip
screenshots

@BrodyHughes BrodyHughes marked this pull request as ready for review January 25, 2024 20:00
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-864a3a48e1591c243cdd88633e610269a29ee2a7.zip
screenshots

key: shortcuts.global.OPEN_CUSTOM_GAS_MENU.display,
type: 'customGasMenu.open',
});
// hackery preventing GweiInputMask from firing an onChange event when opening the menu with KB
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should keep this comment probably to document the nav hack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

key: shortcuts.global.OPEN_CUSTOM_GAS_MENU.display,
type: 'customGasMenu.open',
});
// hackery preventing GweiInputMask from firing an onChange event when opening the menu with KB
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-afe9177c813c11a9309d39042edb1f4134460247.zip
screenshots

Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-586e770bfecb53c7d3d90b0e2826193fefd08a42.zip

Copy link

Here's the packed extension for this build:
rainbowbx-586e770bfecb53c7d3d90b0e2826193fefd08a42.zip

@BrodyHughes BrodyHughes merged commit 497872f into master Jan 30, 2024
17 checks passed
@BrodyHughes BrodyHughes deleted the brody/fix-custom-gas-shortcuts branch January 30, 2024 22:28
Copy link

Here's the packed extension for this build:
rainbowbx-497872f95e2071697f975e6b01b565713b7b2b3f.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants