-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix custom gas shortcuts on L2s #1321
Conversation
Here's the packed extension for this build: |
Here's the packed extension for this build: |
key: shortcuts.global.OPEN_CUSTOM_GAS_MENU.display, | ||
type: 'customGasMenu.open', | ||
}); | ||
// hackery preventing GweiInputMask from firing an onChange event when opening the menu with KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should keep this comment probably to document the nav hack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
key: shortcuts.global.OPEN_CUSTOM_GAS_MENU.display, | ||
type: 'customGasMenu.open', | ||
}); | ||
// hackery preventing GweiInputMask from firing an onChange event when opening the menu with KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
while writing e2e i realized we could still open up the custom gas sheet on L2s with shortcut 'c' and on Polygon this caused a crash. This makes it so 'g' and 'c' shortcuts only work on mainnet, and the 'g' menu only works on polygon.
POW:
Screen.Recording.2024-01-25.at.1.39.18.PM.mov