Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignTypedData simulation #1162

Merged
merged 13 commits into from
Dec 18, 2023
Merged

SignTypedData simulation #1162

merged 13 commits into from
Dec 18, 2023

Conversation

greg-schrammel
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

Copy link

Here's the packed extension for this build:
rainbowbx-33d3776a898568ab3553ea233637707bb66cffb9.zip

Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c96590a5d0c6101f54a82aa12c1803022de2e5b9.zip

Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d19427585b9ed808196192a29642f52e4eefaf74.zip

Copy link

github-actions bot commented Dec 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-c65e55fb79edffd9931d73a4ed616918a85a33ae.zip

@greg-schrammel greg-schrammel marked this pull request as ready for review December 15, 2023 19:53
Copy link

Here's the packed extension for this build:
rainbowbx-d068333c33cc6485a8102b6179f4d67fe780f1d6.zip

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

Here's the packed extension for this build:
rainbowbx-0beaa5bb89327a014c95eaffd6352c9a1c7f06f5.zip

@brunobar79 brunobar79 merged commit d5990af into master Dec 18, 2023
2 checks passed
@brunobar79 brunobar79 deleted the sign-simulation branch December 18, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants