add testnets: Holeski, Arb Sepolia, OP Sepolia #1147
Conversation
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
estebanmino
force-pushed
the
@esteban/add-testnets
branch
from
92c4fcc
to
5fd2380
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
There was a problem hiding this comment.
Functionality looks good! 👌
I pinged Wayne to see if we can get Base Sepolia and Zora Sepolia added at the same time. QuickNode supports Base Sepolia now, so I think we could add it here once our node gets deployed; up to you on order of events. I can sort out the env additions if you want to leave a placeholder
src/core/types/chains.ts
Outdated
| @@ -36,19 +39,70 @@ export const hardhatOptimism: Chain = { | |||
| testnet: true, | |||
| }; | |||
|
|
|||
| export const chainHoleski: Chain = { | |||
There was a problem hiding this comment.
for normalization we might want to use Holesky with y here
There was a problem hiding this comment.
oh lol will change
There was a problem hiding this comment.
about the new chains, we can add them wen ready
src/core/types/chains.ts
Outdated
| network: 'holesky', | ||
| nativeCurrency: { | ||
| decimals: 18, | ||
| name: 'Holeski Ether', |
There was a problem hiding this comment.
Double checked the chain list and am seeing this as Holesky Ether elsewhere
src/core/types/chains.ts
Outdated
| [ChainId.arbitrumGoerli]: chain.arbitrumGoerli.name, | ||
| [ChainId.arbitrumSepolia]: chainArbitrumSepolia.name, | ||
| [ChainId.baseGoerli]: chain.baseGoerli.name, | ||
| [ChainId.zoraTestnet]: chain.zoraTestnet.name, |
There was a problem hiding this comment.
Noticed Zora Goerli had testnet appended here; not exactly sure where that originates.
There was a problem hiding this comment.
updated the name, this name comes from wagmi
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
estebanmino
force-pushed
the
@esteban/add-testnets
branch
2 times, most recently
from
34d60c4
to
5fd2380
Compare
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
adding testnets: Holeski, Arb Sepolia, OP Sepolia
What to test