Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: developer mode, testnet setting tweaks #1113

Merged
merged 20 commits into from
Nov 6, 2023
Merged

feat: developer mode, testnet setting tweaks #1113

merged 20 commits into from
Nov 6, 2023

Conversation

DanielSinclair
Copy link
Collaborator

@DanielSinclair DanielSinclair commented Nov 3, 2023 •
edited
Loading

What changed (plus any additional context for devs)

  • added developerToolsEnabledStore store to replace testnetModeShortcutEnabled in testnetModeStore
  • adopting developerToolsEnabled to replace testnetModeShortcutEnabled
  • added hammer.fill icon to design system for developer mode settings and toggle
  • added developer tools toggle command to command k
  • hide testnet mode toggle in command k when developer mode is disabled
  • hide testnets in networks list when developer mode is disabled
  • added status label to Testnet Mode toggle in More Menu in top right
  • fixed testnet mode icon alignment in More Menu; needs a refactor to emoji width padding
  • allow disabling testnet mode when developer mode is inactive (when enabled by dapp nudge)

Screen recordings / screenshots

Testnet Mode indicator
Screenshot 2023-11-03 at 5 57 37 PM

Developer Tools Setting
Screenshot 2023-11-03 at 5 14 07 PM copy

Hide Testnets when Developer Tools is Disabled
Screenshot 2023-11-03 at 5 14 07 PM
Screenshot 2023-11-03 at 5 14 12 PM

Developer Tools Command K toggle
Screenshot 2023-11-03 at 5 14 28 PM
Screenshot 2023-11-03 at 5 14 19 PM

What to test

  • Network settings and Command K for developer tools and testnet mode

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-1a54402afb5117a58495f1a674535608d905e770.zip
screenshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz

@DanielSinclair DanielSinclair marked this pull request as ready for review November 3, 2023 21:40
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-8d26927014d6ec6fadaf0be4fc220827371336a0.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-dc55acff6a37679e1eca5b8c78f8629c9572be4d.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
rainbowbx-dc55acff6a37679e1eca5b8c78f8629c9572be4d.zip

brunobar79
brunobar79 approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

@christianbaroni
Add Developer Tools toast to ⌘K
f501346 
Sends you to the home screen after enabling to teach you the Testnet Mode shortcut

Remains on the active route after disabling
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-388b5fa89822a4b02683c1b29543becb6f579656.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 4, 2023

Here's the packed extension for this build:
rainbowbx-388b5fa89822a4b02683c1b29543becb6f579656.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d0dca1aae86abb8cdce5b25810bbd4bc02726fe1.zip
screenshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a5a0e5346cd47f934a8e805d921d99d20748e381.zip
screenshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-a5a0e5346cd47f934a8e805d921d99d20748e381.zip
screenshots

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-7ea0afbd12876d8232eb251c34bb74c7580efb50.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Here's the packed extension for this build:
rainbowbx-7ea0afbd12876d8232eb251c34bb74c7580efb50.zip

@DanielSinclair DanielSinclair merged commit e527c17 into master Nov 6, 2023
14 checks passed
@DanielSinclair DanielSinclair deleted the @daniel/testnet-tweaks branch November 6, 2023 07:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e527c17f8c919584539528220fd80613a61966fd.zip

@BrodyHughes BrodyHughes mentioned this pull request Nov 7, 2023
Merged
BrodyHughes pushed a commit that referenced this pull request Nov 15, 2023
@DanielSinclair @christianbaroni @BrodyHughes
feat: developer mode, testnet setting tweaks (#1113)
afe05de 
Co-authored-by: Christian Baroni <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christianbaroni christianbaroni christianbaroni approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@BrodyHughes BrodyHughes Awaiting requested review from BrodyHughes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DanielSinclair @brunobar79 @christianbaroni