Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show testnetbar condition #1110

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Nov 3, 2023

Fixes BX-1119
Figma link (if any):

What changed (plus any additional context for devs)

addressing ticket
https://www.loom.com/share/d0f50a9ea7ea438cb7a8101289a90571

Screen recordings / screenshots

What to test

Copy link

linear bot commented Nov 3, 2023

BX-1119 very small ui thing: if testnet mode is on, and you lock the extension and then close it then ope...

brody said:

very small ui thing: if testnet mode is on, and you lock the extension and then close it then open it again you see the testnet mode banner for a moment at the top of the bx.

1202d09c-bc8f-4a2f-bbce-5dc73552dbc5

Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b37a3dde00969e5c495e079283c7962a6a8983e4.zip

Copy link
Member

@BrodyHughes BrodyHughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, works good 🖖

Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-9601cbc618593300674416b3470e62cc293e3aae.zip

Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
rainbowbx-9601cbc618593300674416b3470e62cc293e3aae.zip

@brunobar79 brunobar79 merged commit 25b3f10 into master Nov 3, 2023
14 of 15 checks passed
@brunobar79 brunobar79 deleted the @esteban/show-testnetbar-condition branch November 3, 2023 19:56
Copy link

github-actions bot commented Nov 3, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-25b3f10d575f28cff282ab05ac9053e662822111.zip

BrodyHughes pushed a commit that referenced this pull request Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants