Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: testnet mode #1057

Merged
merged 38 commits into from
Oct 25, 2023
Merged

feat: testnet mode #1057

merged 38 commits into from
Oct 25, 2023

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Oct 13, 2023

Fixes BX-1076
Figma link (if any):

https://www.figma.com/file/hzfwKOddfRmeVO4KUsG9wM/branch/GDDUZ9kbFUvmcFyvzMQNOl/Rainbow-BX?node-id=9193%3A279613&mode=dev

What changed (plus any additional context for devs)

Testnet mode

  • green boders and top testnet bar all over the extension except for unlock screen
  • networks filtering depending on testnet mode and networks selected in settings
  • transactions filtering depending on testnet mode and networks selected in settings
  • assets filtering depending on testnet mode and networks selected in settings
  • testnet mode shortcut enabled or disabled depending on settings
  • dapp requests on testnet mode, green borders + top bar should send txs to testnets

Screen recordings / screenshots

https://www.loom.com/share/377edd32106d45fb99a08bbe8710bfb3

What to test

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-6755c49707562ce57fde777eb43ee1a87e73bb73.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-5b67a38eed5ad354ef06c644c29845255eea4926.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-e942ca538a86ef090263df50717c7e513015945f.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-6c669890cc239961475e1505a84676331078c207.zip

@linear
Copy link

linear bot commented Oct 18, 2023

BX-1076 Testnets UI

Add testnet warning at the top.
Add testnet switch under settings => networks

Figma link: https://www.figma.com/file/hzfwKOddfRmeVO4KUsG9wM/Rainbow-BX?node-id=9333%3A286148&mode=dev

@estebanmino estebanmino marked this pull request as ready for review October 18, 2023 16:30
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-b9ae0cc2d28455d022cd5f4969adf9201fbc52ec.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-37aee724d275877e1efcbbbbce57def5aab87e81.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-03e029dd571d84218fa8cc860ba56efa07f2b513.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-cf17249d00eb0ba96ce5135fff5f86c7948b78c1.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-93e30ace9e8bda52362a13f37bc1f42e31857a6b.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d7d82aa2277780e22d5a545ab5ba7a4bd0d35a89.zip

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're a beast

</Box>
<MenuItem.TextIcon icon="🕹" />
<Text align="center" color="green" size="12pt" weight="heavy">
Testnet Mode
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any sense in putting this in i18n?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing now

@@ -86,7 +86,7 @@ export function TabHeader({
display="flex"
justifyContent="space-between"
paddingHorizontal="20px"
style={{ maxHeight: 11, textTransform: 'capitalize' }}
// style={{ maxHeight: 11, textTransform: 'capitalize' }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 was this maxHeight breaking UI when the testnet bar is showing? Would prefer to keep it if we can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rolling back

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh ok rolling back

"phrase_copied": "Recovery Phrase Copied",
"copied": "Recovery Phrase Copied"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks like a dupe

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-896b7ba7a4a86fa0a67556e5c6b380c48557a61b.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-f26e6cb83a079ef187aa2b82ba8873526cd33090.zip

Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beast! 💯

@@ -358,7 +361,7 @@ export const ToAddressInput = React.forwardRef<InputRefAPI, ToAddressProps>(
<>
<DropdownInputWrapper
zIndex={2}
dropdownHeight={452}
dropdownHeight={452 - (testnetMode ? TESTNET_MODE_BAR_HEIGHT : 0)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this 452 into core utils dimensions? Not sure if we're planning to use anywhere else

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm i don't think we have the same height anywhere else

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-384dc1973a36769cf12a74a6ad78d1cdd5acea71.zip

@estebanmino estebanmino merged commit 471863b into master Oct 25, 2023
16 checks passed
@estebanmino estebanmino deleted the @esteban/testnet-mode branch October 25, 2023 13:50
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-471863bb467e37e5ea454a5db3a2ed808af9248a.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants