-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: testnet mode #1057
feat: testnet mode #1057
Conversation
Here's the packed extension for this build: |
726e50c
to
9c4e10d
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
2f42307
to
a4b9495
Compare
BX-1076 Testnets UI
Add testnet warning at the top. Figma link: https://www.figma.com/file/hzfwKOddfRmeVO4KUsG9wM/Rainbow-BX?node-id=9333%3A286148&mode=dev |
Here's the packed extension for this build: |
a4b9495
to
10d71b1
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
e734202
to
4e630a0
Compare
Here's the packed extension for this build: |
4e630a0
to
107cac5
Compare
Here's the packed extension for this build: |
107cac5
to
0af734a
Compare
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're a beast
</Box> | ||
<MenuItem.TextIcon icon="🕹" /> | ||
<Text align="center" color="green" size="12pt" weight="heavy"> | ||
Testnet Mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any sense in putting this in i18n?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing now
@@ -86,7 +86,7 @@ export function TabHeader({ | |||
display="flex" | |||
justifyContent="space-between" | |||
paddingHorizontal="20px" | |||
style={{ maxHeight: 11, textTransform: 'capitalize' }} | |||
// style={{ maxHeight: 11, textTransform: 'capitalize' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👀 was this maxHeight breaking UI when the testnet bar is showing? Would prefer to keep it if we can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rolling back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh ok rolling back
static/json/languages/en_US.json
Outdated
"phrase_copied": "Recovery Phrase Copied", | ||
"copied": "Recovery Phrase Copied" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like a dupe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
right
Here's the packed extension for this build: |
Here's the packed extension for this build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beast! 💯
@@ -358,7 +361,7 @@ export const ToAddressInput = React.forwardRef<InputRefAPI, ToAddressProps>( | |||
<> | |||
<DropdownInputWrapper | |||
zIndex={2} | |||
dropdownHeight={452} | |||
dropdownHeight={452 - (testnetMode ? TESTNET_MODE_BAR_HEIGHT : 0)} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we move this 452 into core utils dimensions? Not sure if we're planning to use anywhere else
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hm i don't think we have the same height anywhere else
9b77367
to
b6e6cb3
Compare
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-1076
Figma link (if any):
https://www.figma.com/file/hzfwKOddfRmeVO4KUsG9wM/branch/GDDUZ9kbFUvmcFyvzMQNOl/Rainbow-BX?node-id=9193%3A279613&mode=dev
What changed (plus any additional context for devs)
Testnet mode
Screen recordings / screenshots
https://www.loom.com/share/377edd32106d45fb99a08bbe8710bfb3
What to test