Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prefetch dapp metadata without status #1038

Merged
merged 6 commits into from
Oct 6, 2023
Merged

fix: prefetch dapp metadata without status #1038

merged 6 commits into from
Oct 6, 2023

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Oct 4, 2023 •
edited
Loading

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

Screen recordings / screenshots

What to test

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

Here's the packed extension for this build:
rainbowbx-fbc77de0dcdf00f86c5ddc3fd8579a880c816efc.zip

greg-schrammel
greg-schrammel reviewed Oct 5, 2023
View reviewed changes
src/core/providers/RainbowProvider.ts
Comment on lines +120 to +123
this.backgroundMessenger?.send(
'rainbow_prefetchDappMetadata',
window.location.href,
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder to check if this is hitting the local cache or spamming the api on every provider request

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thankss

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok i blocked prefetch if we already have the data to not trigger unnecessary requests, thanks for the catch

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-e70a5257bc54b5b2d22d0e876961a54db8a10ed9.zip

brunobar79
brunobar79 approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝

@estebanmino estebanmino force-pushed the @esteban/removing-status-dapp-metadata branch from 0424073 to 599ffa4 Compare October 6, 2023 13:52
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b21d740aa3cebe328d430ededcb0071793926eb7.zip
screenshots

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-b21d740aa3cebe328d430ededcb0071793926eb7.zip
screenshots

@estebanmino estebanmino force-pushed the @esteban/removing-status-dapp-metadata branch from 7eee6d0 to 9e311b1 Compare October 6, 2023 16:56
@estebanmino estebanmino merged commit 0713198 into master Oct 6, 2023
15 checks passed
@estebanmino estebanmino deleted the @esteban/removing-status-dapp-metadata branch October 6, 2023 17:14
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Here's the packed extension for this build:
rainbowbx-071319884262f2d3c60513dbefa1cac82fbe3457.zip

@BrodyHughes BrodyHughes mentioned this pull request Oct 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-schrammel greg-schrammel greg-schrammel approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@derHowie derHowie Awaiting requested review from derHowie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanmino @brunobar79 @greg-schrammel