[BX-1057] ‘Del’ text slightly exceeds button width #1030
Conversation
BX-1057 ‘Del’ text slightly exceeds button width
brody said:
|
|
Here's the packed extension for this build: |
Good call, fixed. 
|
|
Here's the packed extension for this build: |
hm it doesn't look fixed 
|
| @@ -11,13 +11,14 @@ export const ShortcutHint = ({ | |||
| }) => { | |||
| const height = small ? '14px' : '18px'; | |||
| const width = small ? '16px' : '18px'; | |||
| const widthKey = hint?.length || 0 > 1 ? 'minWidth' : 'width'; | |||
There was a problem hiding this comment.
| const widthKey = hint?.length || 0 > 1 ? 'minWidth' : 'width'; | |
| const widthKey = (hint?.length || 0) > 1 ? 'minWidth' : 'width'; |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
What changed (plus any additional context for devs)
Let multicharacter button strings expand the width of the bubble keys
Screen recordings / screenshots
What to test
Make sure button strings have sufficient horizontal padding inside the bubble keys