Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-1053] Tokens should be default tab selection after switching wallets #1029

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

derHowie
Copy link
Member

@derHowie derHowie commented Oct 3, 2023

What to test

Make sure you land on the tokens tab after selecting another address

@linear
Copy link

linear bot commented Oct 3, 2023

BX-1053 Tokens should be default tab selection after switching wallets

brody said:

is the default screen when switching wallets supposed to be txn history or tokens? atm its defaulting to txn history

fbc621a9-17b7-41ca-8c6d-160c4194a353

@github-actions
Copy link

github-actions bot commented Oct 3, 2023

Here's the packed extension for this build:
rainbowbx-54e4ff7e7d2553d12f6583f327eec95341e3c736.zip

Copy link
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is working fine but should we add it to switching wallets via shortcuts?

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Here's the packed extension for this build:
rainbowbx-bae93e55fa31e27b737e6175a7fab925d85f61cb.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ddb87685d810938ce6cb5e40985dfc85808766e5.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-1040333bed905a0ff0b244924bbe5da0b417d4dd.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-7b5ba663c652ad04b63df0fc096dcf23770e264f.zip

@brunobar79 brunobar79 merged commit 82596dd into master Oct 10, 2023
14 checks passed
@brunobar79 brunobar79 deleted the @chris/select-address-tokens-default-nav branch October 10, 2023 17:50
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-82596ddf62a10428b9dd1180a91d740e904f216e.zip

@BrodyHughes BrodyHughes mentioned this pull request Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants