add sanitizeTypeData function with tests #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BX-1051 Check if EIP 712 injection issue affects BX UI
https://www.coinspect.com/wallet-EIP-712-injection-vulnerability/ Sister ticket in App: APP-810 |
|
Here's the packed extension for this build: |
greg-schrammel
approved these changes
Oct 2, 2023
derHowie
approved these changes
Oct 3, 2023
|
Here's the packed extension for this build: |
derHowie
pushed a commit
that referenced
this pull request
Oct 4, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-1051
Figma link (if any):
What changed (plus any additional context for devs)
Added sanitize function to filter out fields that doesn't match the types in the message that's being signed to prevent phishing attempts. With this fix what you see is what you sign.
Screen recordings / screenshots
What to test
Unit tests were added