[BX-1002][BX-1005] Support keyboard navigation within swap settings / Support Flip Assets Selectable with Tab/Arrow #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derHowie
commented
Sep 29, 2023
Comment on lines
+47
to
+50
| boxShadow={`0px 0px 1px 2px transparent`} | ||
| activeBoxShadow={`0px 0px 2px 4px ${ | ||
| accentColor || avatar?.color || '#268FFF' | ||
| }`} |
There was a problem hiding this comment.
original code was broken, added transparent box shadow because it behaves oddly without it.
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
estebanmino
approved these changes
Oct 2, 2023
greg-schrammel
approved these changes
Oct 2, 2023
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Added keyboard navigation to the swap settings screen. Made flip assets button selectable with the keyboard. Fixed the active state of our
Togglecomponent. Made focused toggles generable interactive with the enter key.Screen recordings / screenshots
PoW: https://recordit.co/fQQeoVGy52
What to test
Make sure swap settings can be pulled up using keyboard nav, and that all settings can be selected via keyboard. Ensure the active state on the toggle behaves appropriately. Check that using the keyboard to flip swap assets works and behaves the same as clicking and pressing 'F'.