Switched the tracker to always be stored in the session instead of it being swapped in and out of the env['tracker']. #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
being swapped in and out of the env['tracker'].
* move-tracker-to-session: Updated all tests to pass Switched the tracker to always be stored in the session instead of it being swapped in and out of the env['tracker'].
|
@jclusso we released a new patch with some changes to internal state handling to make the middleware more thread safe. Could you incorporate the changes here as well? 👍 |
|
@DonSchado, I’ll look into doing this later today. |
…session * railslove/master: version up Use local variables in rack middleware to prevent instance state changes (railslove#151) Make middleware thread safe
|
@DonSchado I merged the latest code on master into my branch. |
|
@bumi what do you think? :) |
|
Closing this since we no longer use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #152