Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: enrich dev setup #290

Merged
merged 4 commits into from
Dec 12, 2024
Merged

Chore: enrich dev setup #290

merged 4 commits into from
Dec 12, 2024

Conversation

janz93
Copy link
Contributor

@janz93 janz93 commented Dec 11, 2024

What changes are introduced?

  • Enable setup UI as default
  • correct typos

Why are these changes introduced?

  • Make development experiences easier
  • Increase the understanding for non native speakers

How are these changes made?

  • Adjust dev docker setup
  • Correct typos

How was it tested? (optional)

remove this section, when you don't add further information

Some code, especially infrastructure code (say HELM or Kubernetes yaml files) are harder to test. So it’s important to let the reviewer know how you tested them in case you can’t check in tests. Alternatively, you can explain to the reviewer how to test it locally if necessary. Showing the results of tests you’ve run in this section if none are visible in the diff is also very helpful.

  • Specs
  • Locally
  • Staging

@janz93 janz93 marked this pull request as ready for review December 12, 2024 09:03
to make the setup easier
remove the need to build the container everytime a file was changed
help the user to better find error infos
@janz93 janz93 merged commit b2e21b7 into main Dec 12, 2024
3 checks passed
@janz93 janz93 deleted the chore/dev-setup branch December 12, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant