Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: background error tracking #289

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Fix: background error tracking #289

merged 3 commits into from
Dec 12, 2024

Conversation

janz93
Copy link
Contributor

@janz93 janz93 commented Dec 11, 2024

What changes are introduced?

fix error tracking for background jobs

Why are these changes introduced?

Enable better debugging

How are these changes made?

  • Add sentry-sidekiq gem
  • Add env info to rollbar

How was it tested? (optional)

remove this section, when you don't add further information

Some code, especially infrastructure code (say HELM or Kubernetes yaml files) are harder to test. So it’s important to let the reviewer know how you tested them in case you can’t check in tests. Alternatively, you can explain to the reviewer how to test it locally if necessary. Showing the results of tests you’ve run in this section if none are visible in the diff is also very helpful.

  • Specs
  • Locally
  • Staging

sentry has a dedicated gem for sidekiq which needs to be installed and
configured in order to submit errors
for a better error investigation the environment can help
in the past it was forgotten to increase the version file on a new release.
This logic now automatically uses the docker tag as new version info
@janz93 janz93 force-pushed the fix/error-tracking branch from 5ed8c0b to a2fee17 Compare December 12, 2024 09:04
@janz93 janz93 merged commit 611ce0c into main Dec 12, 2024
3 checks passed
@janz93 janz93 deleted the fix/error-tracking branch December 12, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant