Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update moment.js to 2.24.0 #3201

Merged
merged 1 commit into from
Nov 4, 2019
Merged

Update moment.js to 2.24.0 #3201

merged 1 commit into from
Nov 4, 2019

Conversation

eitoball
Copy link
Contributor

@eitoball eitoball commented Oct 3, 2019

Fixes #3182

vendor/assets/javascripts/rails_admin/moment-with-locales.js is created in the following.

$ git clone https://github.com/moment/moment.git
$ cd moment
$ git checkout 2.24.0
$ cat moment.js locale/*.js > moment-with-locale.js
$ cp moment-with-locale.js <rails_admin vendor assets directory>

@eitoball
update moment.js to 2.24.0
d4c58b9 
$ git clone https://github.com/moment/moment.git
$ cd moment
$ cat moment.js locale/*.js > moment-with-locale.js
$ cp moment-with-locale.js <rails_admin vendor assets directory>
@mshibuya mshibuya merged commit 6a735e5 into railsadminteam:master Nov 4, 2019
@mshibuya
Copy link
Member

mshibuya commented Nov 4, 2019

Thanks!

@tom-lord tom-lord mentioned this pull request Jan 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security Vulnerability in moment
2 participants
@eitoball @mshibuya