Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issues #1524, #2332, #2691
It is based on https://github.com/sferik/rails_admin/pull/1567/files.
PaperTrail stores a base_class for each subclass, so we can't fetch versions with searching by subclass. STI model allows us to fetch records with query condition which includes STI type, so
model.model.all
should return a valid AR relation for current STI type and we can fetch a versions by this relation.When we have a deal with object versions think we can't do better than to use native PaperTrail method versions, so
object.versions
should work well.These changes were checked on our production db.
Here is illustration how PaperTrail works: