Not paginating when showing all history #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note, there are no unit tests (yet). I haven't had the time to figure out how to add/run the tests yet |
|
Now with tests (and removing unnecessary 'fix' to |
minyoung
changed the title
mshibuya
added a commit
that referenced
this pull request
Mar 21, 2016
Not paginating when showing all history
|
Merged in, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When showing all history, we don't use paging (we're showing all history after all). But since Kaminari only adds extension methods when paging is used, so we end up in a situation where the paging methods are missing (which we assume are there). This happens when we're showing all history
Related issue:
#2503