Check AR validators to decide if a field is required #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uired Previously, a field's "required" or "optional" status in the create/edit form was based only on that field's nullable status in the database schema. This led to cases where a field was indicated "optional" but you'd get an error if you tried to save with that field empty. This commit adds checks for two kinds of validations: ActiveModel::Validations::PresenceValidator and ActiveModel::Validations::NumericalityValidator with :allow_nil=>false. There might well be other validations that cause the fields to be required, but these are the two that I know about.
|
Looks good. Do you have any interest in being added as a committer? I'm getting tired of accepting your pull requests. ;) |
|
Yes, please, although I'll probably continue to hassle you and the other committers for code reviews. |
|
Added! I'm always happy to give a code review. In general, please leave pull requests for me to merge but feel free to push your own code directly to master. |
|
Thank you! |
|
Welcome aboard on my behalf as well! :) |
Closed
grillermo
added a commit
to go-tandem/rails_admin
that referenced
this pull request
Jun 2, 2015
…-without-payment-method Feature/redirect without payment method
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close issue 89 and issue 121.