active_record_extensions.rb#safe_send inefficiently searches for an attribute #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents calling read_attribute once for every column in the table when searching for the attribute thereby reducing calls to expensive methods like generated_external_attribute_methods
mshibuya
added a commit
that referenced
this pull request
Jul 3, 2012
active_record_extensions.rb#safe_send inefficiently searches for an attribute
|
Thanks for cleaning up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently active_record_extensions#L20 uses
self.attributes.find{ |k,v| k.to_s == value.to_s }to check the existence of an attribute, but this ends up unnecessarily calling the costlyActiveRecord AttributeMethods ClassMethods#generated_external_attribute_methodsmethod.It would be more efficient to look up the existence of an attribute at L20 with
self.has_attribute?(value)