Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deployment.md #3331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions docs/deployment.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@
Webpacker hooks up a new `webpacker:compile` task to `assets:precompile`, which gets run whenever you run `assets:precompile`.
If you are not using Sprockets `webpacker:compile` is automatically aliased to `assets:precompile`.

```

## Heroku

In order for your Webpacker app to run on Heroku, you'll need to do a bit of configuration before hand.
Expand All @@ -19,10 +17,10 @@ git push heroku master

We're essentially doing the following here:

* Creating an app on Heroku
* Creating a Postgres database for the app (this is assuming that you're using Heroku Postgres for your app)
* Creating an app on Heroku.
* Creating a Postgres database for the app (this is assuming that you're using Heroku Postgres for your app).
* Adding the Heroku NodeJS and Ruby buildpacks for your app. This allows the `npm` or `yarn` executables to properly function when compiling your app - as well as Ruby.
* Pushing your code to Heroku and kicking off the deployment
* Pushing your code to Heroku and kicking off the deployment.

## Nginx

Expand Down Expand Up @@ -78,7 +76,7 @@ If you want to serve Brotli compressed files with nginx, you will need to instal

Once installed, you need to load the module. As we want to serve the pre-compressed files, we only need the static module. Add the following line to your `nginx.conf` file and reload nginx:

```
```nginx
load_module modules/ngx_http_brotli_static_module.so;
```

Expand Down
Loading