Support node LTS and future "Current" releases #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drops support for Node.js 13 and 15. https://nodejs.org/en/about/releases/
|
@aried3r Why is this required? What benefit? |
It is not required, but EOL node.js versions have been dropped in the past, see #2749 and #2993. Since webpacker 6 stable is not yet released, I thought it'd be a good idea to drop EOL node.js versions unless webpacker is going to keep maintaining support for them. However they are not part of the test matrix as of #3185 (that's my own PR, however). WDYT? |
|
And we could change https://github.com/rails/webpacker/blob/master/.github/workflows/js-lint.yml#L12 to What about that #3249? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops support for Node.js 13 and 15.
https://nodejs.org/en/about/releases/