Skip to content

Commit

Permalink
Merge branch 'master' into issue-464-merge-webpacker-lite-into-webpacker
Browse files Browse the repository at this point in the history
  • Loading branch information
gauravtiwari authored Aug 10, 2017
2 parents 5599fd6 + 5537e0e commit bb71faa
Show file tree
Hide file tree
Showing 25 changed files with 266 additions and 162 deletions.
42 changes: 21 additions & 21 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,27 +18,27 @@ Style/BracesAroundHashParameters:
Enabled: true

# Align `when` with `case`.
Style/CaseIndentation:
Layout/CaseIndentation:
Enabled: true

# Align comments with method definitions.
Style/CommentIndentation:
Layout/CommentIndentation:
Enabled: true

# No extra empty lines.
Style/EmptyLines:
Layout/EmptyLines:
Enabled: true

# In a regular class definition, no empty lines around the body.
Style/EmptyLinesAroundClassBody:
Layout/EmptyLinesAroundClassBody:
Enabled: true

# In a regular method definition, no empty lines around the body.
Style/EmptyLinesAroundMethodBody:
Layout/EmptyLinesAroundMethodBody:
Enabled: true

# In a regular module definition, no empty lines around the body.
Style/EmptyLinesAroundModuleBody:
Layout/EmptyLinesAroundModuleBody:
Enabled: true

# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
Expand All @@ -47,49 +47,49 @@ Style/HashSyntax:

# Method definitions after `private` or `protected` isolated calls need one
# extra level of indentation.
Style/IndentationConsistency:
Layout/IndentationConsistency:
Enabled: true
EnforcedStyle: rails

# Two spaces, no tabs (for indentation).
Style/IndentationWidth:
Layout/IndentationWidth:
Enabled: true

Style/SpaceAfterColon:
Layout/SpaceAfterColon:
Enabled: true

Style/SpaceAfterComma:
Layout/SpaceAfterComma:
Enabled: true

Style/SpaceAroundEqualsInParameterDefault:
Layout/SpaceAroundEqualsInParameterDefault:
Enabled: true

Style/SpaceAroundKeyword:
Layout/SpaceAroundKeyword:
Enabled: true

Style/SpaceAroundOperators:
Layout/SpaceAroundOperators:
Enabled: true

Style/SpaceBeforeFirstArg:
Layout/SpaceBeforeFirstArg:
Enabled: true

# Defining a method with parameters needs parentheses.
Style/MethodDefParentheses:
Enabled: true

# Use `foo {}` not `foo{}`.
Style/SpaceBeforeBlockBraces:
Layout/SpaceBeforeBlockBraces:
Enabled: true

# Use `foo { bar }` not `foo {bar}`.
Style/SpaceInsideBlockBraces:
Layout/SpaceInsideBlockBraces:
Enabled: true

# Use `{ a: 1 }` not `{a:1}`.
Style/SpaceInsideHashLiteralBraces:
Layout/SpaceInsideHashLiteralBraces:
Enabled: true

Style/SpaceInsideParens:
Layout/SpaceInsideParens:
Enabled: true

# Check quotes usage according to lint rule below.
Expand All @@ -98,15 +98,15 @@ Style/StringLiterals:
EnforcedStyle: double_quotes

# Detect hard tabs, no hard tabs.
Style/Tab:
Layout/Tab:
Enabled: true

# Blank lines should not have any spaces.
Style/TrailingBlankLines:
Layout/TrailingBlankLines:
Enabled: true

# No trailing whitespace.
Style/TrailingWhitespace:
Layout/TrailingWhitespace:
Enabled: true

# Use quotes for string literals when they are enough.
Expand Down
9 changes: 6 additions & 3 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@
resolved_paths: [] # empty by default
```
- `Webpacker::Compiler.fresh?` and `Webpacker::Compiler.stale?` answer the question of whether compilation is needed.
The old `Webpacker::Compiler.compile?` predicate is deprecated.

### Fixed

- Update `webpack-dev-server.tt` to respect RAILS_ENV and NODE_ENV values [#502](https://github.com/rails/webpacker/issues/502)
Expand All @@ -28,14 +31,14 @@
- Add `compile` option to `config/webpacker.yml` for configuring lazy compilation of packs when a file under tracked paths is changed [#503](https://github.com/rails/webpacker/pull/503). To enable expected behavior, update `config/webpacker.yml`:

```yaml
default: &default
compile: false
test:
compile: true
development:
compile: true
production:
compile: false
```

- Make test compilation cacheable and configurable so that the lazy compilation
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ gemspec

gem "rails"
gem "rake", ">= 11.1"
gem "rubocop", ">= 0.47", require: false
gem "rubocop", ">= 0.49", require: false

group :test do
gem "minitest", "~> 5.0"
Expand Down
13 changes: 7 additions & 6 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ PATH
specs:
webpacker (2.0)
activesupport (>= 4.2)
multi_json (~> 1.2)
railties (>= 4.2)

GEM
Expand Down Expand Up @@ -64,10 +63,10 @@ GEM
mime-types-data (3.2016.0521)
mini_portile2 (2.1.0)
minitest (5.10.1)
multi_json (1.12.1)
nio4r (1.2.1)
nokogiri (1.7.0.1)
mini_portile2 (~> 2.1.0)
parallel (1.12.0)
parser (2.4.0.0)
ast (~> 2.2)
powerpack (0.1.1)
Expand Down Expand Up @@ -97,9 +96,11 @@ GEM
method_source
rake (>= 0.8.7)
thor (>= 0.18.1, < 2.0)
rainbow (2.2.1)
rainbow (2.2.2)
rake
rake (12.0.0)
rubocop (0.47.1)
rubocop (0.49.1)
parallel (~> 1.10)
parser (>= 2.3.3.1, < 3.0)
powerpack (~> 0.1)
rainbow (>= 1.99.1, < 3.0)
Expand All @@ -117,7 +118,7 @@ GEM
thread_safe (0.3.6)
tzinfo (1.2.2)
thread_safe (~> 0.1)
unicode-display_width (1.1.3)
unicode-display_width (1.3.0)
websocket-driver (0.6.5)
websocket-extensions (>= 0.1.0)
websocket-extensions (0.1.2)
Expand All @@ -130,7 +131,7 @@ DEPENDENCIES
minitest (~> 5.0)
rails
rake (>= 11.1)
rubocop (>= 0.47)
rubocop (>= 0.49)
webpacker!

BUNDLED WITH
Expand Down
Loading

0 comments on commit bb71faa

Please sign in to comment.