Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instantiate view with empty template cache #304

Merged
merged 1 commit into from
Nov 4, 2020
Merged

Instantiate view with empty template cache #304

merged 1 commit into from
Nov 4, 2020

Conversation

stephannv
Copy link

Fix #303

@stephannv stephannv mentioned this pull request Nov 3, 2020
Closed
@gsamokovarov
Copy link
Collaborator

Is this change working with Rails 6 as well?

@stephannv
Copy link
Author

Yes @gsamokovarov , I tried with rails 6 and 6.1.rc1 and worked fine. But I don't know about older Rails versions.

@gsamokovarov
Copy link
Collaborator

Rails 6 support is what we're aiming for, so this is good. Thanks for the change!

@gsamokovarov gsamokovarov merged commit 5451b57 into rails:master Nov 4, 2020
@stephannv
Copy link
Author

@gsamokovarov, I thank you for your great work maintaining this project. It's a pleasure to help.

@stephannv stephannv mentioned this pull request Nov 5, 2020
Merged
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 8, 2022
@mishina2228
Address the change of ActionView::Base.new in Rails 6
cdcee07 
Same change as rails#304
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 8, 2022
@mishina2228
Address the change of ActionView::Base.new in Rails 6
1c40423 
Same change as rails#304
mishina2228 added a commit to mishina2228/web-console that referenced this pull request Jun 9, 2022
@mishina2228
Address the change of ActionView::Base.new in Rails 6
3165955 
Same change as rails#304
@mishina2228 mishina2228 mentioned this pull request Jun 9, 2022
Merged
patrickm68 added a commit to patrickm68/web-console that referenced this pull request Dec 1, 2022
@patrickm68
Address the change of ActionView::Base.new in Rails 6
0ec69b7 
Same change as rails/web-console#304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Breaking with Rails 6.1.rc1.
2 participants
@stephannv @gsamokovarov