Bindex Integration #237
Merged
Bindex Integration #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expect the gem to _just work_ across the platforms.
All of them helped us a lot throughout the years.
| @@ -1,11 +1,11 @@ | |||
| language: ruby | |||
|
|
|||
| rvm: | |||
| - 2.3.1 | |||
There was a problem hiding this comment.
Should we remove the tests with 2.3 and 2.2?
README.markdown
Outdated
| @@ -162,7 +148,7 @@ All of _Web Console_ sessions are stored in memory. If you happen to run on a | |||
| multi-process server (like Unicorn) you may get unavailable session errors | |||
| while the server is still running. This is because a request may hit a | |||
| different worker (process) that doesn't have the desired session in memory. | |||
|
|
|||
| https://github.com/gsamokovarov/web-console/tree/bindex | |||
rafaelfranca
approved these changes
Mar 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanna bring back the JRuby support for
3.5.0as I have been getting requests for it and it was easier for me to reuse the integration I have done for bindex. Bindex has been a side-project of mine that explored support with native API's for all the major Ruby interpreters. It eventually led to theDebugInspectorandTracePointimplementation for CRuby that we had since3.0. I think it's stable enough to be used inweb-consolenow. I have been testing it for a while, but a release will help me validate it.JRuby
1.7reports itself as Ruby1.9. While bindex can support it, Rails needs JRuby9k, which reports itself as2.3, so only9kis supported. CRuby and Rubinius support is intact.