Skip to content

Commit

Permalink
Change config.development_only default to close #150
Browse files Browse the repository at this point in the history
Version 2.2.0 explicitly prevents test running with web-console enabled.
While, a saner default, it does break rails new for 4.2.3 and below.
Keep it off, until 4.2.4 is released, so we don't have broken tests by
default on rails new.
  • Loading branch information
gsamokovarov committed Jul 10, 2015
1 parent 9a376c1 commit 4398b83
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 2 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,20 @@

## master (unreleased)

## 2.2.1

* [#150](https://github.com/rails/web-console/pull/150) Change config.development_only default until 4.2.4 is released.

## 2.2.0

* [#140](https://github.com/rails/web-console/pull/140) Add the ability to close the console on each page ([@sh19910711])
* [#135](https://github.com/rails/web-console/pull/135) Run the console only in development mode and raise warning in tests ([@frenesim])
* [#134](https://github.com/rails/web-conscle/pull/134) Force development only web console by default ([@gsamokovarov])
* [#123](https://github.com/rails/web-console/pull/123) Replace deprecated `alias_method_chain` with `alias_method` ([@jonatack])

## 2.1.3

* Fix remote code execution vulnerability in Web Console. CVE-2015-3224.
* [#123](https://github.com/rails/web-console/pull/123) Replace deprecated `alias_method_chain` with `alias_method` ([@jonatack])

## 2.1.2

Expand Down
4 changes: 4 additions & 0 deletions lib/web_console/railtie.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ class Railtie < ::Rails::Railtie
config.web_console = ActiveSupport::OrderedOptions.new
config.web_console.whitelisted_ips = %w( 127.0.0.1 ::1 )

# See rails/web-console#150 and rails/rails#20319. Revert when Ruby on
# Rails 4.2.4 is released.
config.web_console.development_only = false

initializer 'web_console.initialize' do
require 'web_console/extensions'

Expand Down
2 changes: 1 addition & 1 deletion lib/web_console/version.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module WebConsole
VERSION = '2.2.0'
VERSION = '2.2.1'
end

0 comments on commit 4398b83

Please sign in to comment.