🌈 Update Thor::Actions#inside to return the value yielded by the block
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that calling code can inspect & use the value.
`FileUtils.cd` only returns the value of the block in Ruby >= 2.6.
|
@rafaelfranca any thoughts on this? |
jordan-brough
changed the title
Thor::Actions#inside to return the value yielded by the blockThor::Actions#inside to return the value yielded by the block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌈
So that calling code can more conveniently inspect & use this value.
The value previously returned by this method doesn't seem useful so this seems like a safe change to make.
If this looks OK, should I also update the CHANGELOG?