Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily require readline #689

Merged
merged 1 commit into from
Nov 11, 2019
Merged

Lazily require readline #689

merged 1 commit into from
Nov 11, 2019

Commits on Nov 6, 2019

  1. Lazily require readline

    The current implementation of readline has issues under Windows, and
    those issues prevent thor from being used. For example, in our bundler
    Windows CI, we had to patch `rb-readline` to workaround some issues
    because `rb-readline` (the default `readline` provider on Windows)
    couldn't be required. Moreover, we still get some issues when requiring
    `rb-readline` like
    
    ```
    HOME environment variable (or HOMEDRIVE and HOMEPATH) must be set and point to a directory
    ```
    
    Since in some situations the part of thor using `readline`
    (`Thor::LineEditor`) is not required, for example, in most of CI
    situations. I thought it could be a good idea to lazily require
    `readline`.
    deivid-rodriguez committed Nov 6, 2019
    Configuration menu
    Copy the full SHA
    7061b06 View commit details
    Browse the repository at this point in the history