Prefer require_relative for internal requires
#668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use
require_relativefor internal requires now that ruby 1.8 support has been dropped. It should be faster and it makes it more clear that the file being required is in the same library.Also, it's nice to do this for
bundler(which vendors a copy ofthor) because given theLOAD_PATHmanipulationbundlerdoes, and that a copy of bundler is now always present in theLOAD_PATHby default in every installation of ruby,require_relativeis safer because we are sure we never end up requiring a different copy of bundler than the one we're currently running.